Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update codeowners file to exclude documentation team for approvals on cspell json file changes #6141

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Chore: Update codeowners file to exclude documentation team for approvals on cspell json file changes #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69806e
feat: remove docs team approval for spelling changes using codeowners
sowmya-kota07 Oct 31, 2023
23789f8
chore: update readme for cspell check
sowmya-kota07 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/src/**/cli/ @josefaidt @aws-amplify/documentation-team

#Studio
/src/pages/console/ @wrpeck @aws-amplify/documentation-team
/src/pages/console/ @dbanksdesign @aws-amplify/documentation-team

#Analytics
/src/**/**/analytics @abdallahshaban557 @aws-amplify/documentation-team
Expand Down Expand Up @@ -97,3 +97,5 @@
/src/public @aws-amplify/documentation-team
/src/styles @aws-amplify/documentation-team
/src/utils @aws-amplify/documentation-team

cspell.json
1 change: 1 addition & 0 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ We welcome contributions to the documentation site! Here's how to do it:
2. If any files have been deleted with your PR, please add the redirects required to [`redirects.json`](https://github.com/aws-amplify/docs/blob/main/redirects.json) and ensure that the `redirects-needed` label has been added.
- Please see the [Amplify Hosting user guide](https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html) for guidance on values and ordering.
- Please note that there is a manual step for the Docs Engineering team to complete before the redirects are live.
4. Please add the words to [cpsell.json] https://github.com/aws-amplify/docs/blob/main/cspell.json if needed or correct spelling if `Spellcheck` workflow fails.

**What's next?** After your PR is reviewed and all tests pass, it will be merged and the branch will be deleted.

Expand Down