Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom example to use cdkv2 imports #5823

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

ykethan
Copy link
Contributor

@ykethan ykethan commented Aug 29, 2023

Description of changes:

updates the example to use aws-cdk-lib

Related GitHub issue #, if available:

aws-amplify/amplify-cli#13164

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ykethan ykethan requested a review from a team as a code owner August 29, 2023 20:45
@ykethan ykethan added amplify/cli Issues tied to CLI product-owner-review-needed Current step in the approval process requires a PM review technical-review-needed labels Aug 29, 2023
@ykethan ykethan changed the title update custom example to use cdkv2 imports and add prereq to install … update custom example to use cdkv2 imports Aug 29, 2023
@ykethan ykethan requested a review from a team August 30, 2023 13:29
src/pages/cli/start/install.mdx Outdated Show resolved Hide resolved
@josefaidt josefaidt removed the product-owner-review-needed Current step in the approval process requires a PM review label Aug 30, 2023
@jacoblogan jacoblogan merged commit bb81941 into main Sep 22, 2023
10 checks passed
@jacoblogan jacoblogan deleted the update-cdk-import-and-install-page branch September 22, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/cli Issues tied to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants