chore(auth): refractor handleSignedIn method in AuthenticatorViewModel #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: https://github.com/aws-amplify/amplify-ui-android/issues/189
Description of changes:
instead of "manually" moveTo SignIn state after signing out, we could listen to HubEvents: AuthChannelEventName.SIGNED_OUT, which was implemented in start() method of AuthenticatorViewModel.kt.
How did you test these changes?
(Please add a line here how the changes were tested)
Instead of testing the resulting state (which should be SignIn), we just need to make sure that signOut() is being called when getCurrentUser errors with SessionExpiredException during start
Documentation update required?
General Checklist
fix(liveness): message
,fix(authenticator): message
,fix(all): message
)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.