Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(liveness): Use backend-provided values for some FaceDectector values #191

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

vincetran
Copy link
Member

Issue #, if available:
N/A

Description of changes:
This is a follow up to aws-amplify/amplify-android#2883 where that PR starts passing server-provided values to the client, this removes the hard coded values to use those server-provided values.

How did you test these changes?
"Hardcoded" different values from the Amplify library to see them reflected on the Liveness UI Component

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners September 23, 2024 20:54
@vincetran vincetran merged commit 2856562 into feature/no-light-sku Sep 24, 2024
1 check passed
@vincetran vincetran deleted the liveness-dynamic-config branch September 24, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants