fix: mac Smoke tests #14316
Merged
fix: mac Smoke tests #14316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Github put out a new version of their Mac runner and now there are multiple
iPhone 16 Pro Maxs that we could be using to run our tests. Fastlane does not like options and fails since it detects thatiPhone 16 Pro Maxcould be on OS 18 or OS 26. Tried locking us toiPhone 16 Pro Maxwith OS 18 but Mac smoketests were still failing due to timeouts.Ended up moving us to a lighter weight iPhone version (
iPhone 6) and altering the fastlane timeouts and retries for Mac tests to make them more forgiving than the default. Windows and Linux are still using default fastlane timeouts.Description of how you validated changes
Successful smoketest run: https://github.com/aws-amplify/amplify-cli/actions/runs/19044331468
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.