Skip to content

feat(gen2-migration): implement clean working directory validation for gen2 migration #14314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: gen2-migration
Choose a base branch
from
Draft

feat(gen2-migration): implement clean working directory validation for gen2 migration #14314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/amplify-cli/src/commands/gen2-migration/_validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { $TSContext, AmplifyError } from '@aws-amplify/amplify-cli-core';
import { printer } from '@aws-amplify/amplify-prompts';
import { DescribeChangeSetOutput } from '@aws-sdk/client-cloudformation';
import { STATEFUL_RESOURCES } from './stateful-resources';
import execa from 'execa';

export class AmplifyGen2MigrationValidations {
constructor(private readonly context: $TSContext) {}
Expand All @@ -12,7 +13,28 @@ export class AmplifyGen2MigrationValidations {
}

public async validateWorkingDirectory(): Promise<void> {
printer.warn('Not implemented');
const { stdout: statusOutput } = await execa('git', ['status', '--porcelain']);
if (statusOutput.trim()) {
throw new AmplifyError('MigrationError', {
message: 'Working directory has uncommitted changes',
resolution: 'Commit or stash your changes before proceeding with migration.',
});
}

try {
const { stdout: unpushedOutput } = await execa('git', ['log', '@{u}..', '--oneline']);
if (unpushedOutput.trim()) {
throw new AmplifyError('MigrationError', {
message: 'Local branch has unpushed commits',
resolution: 'Push your commits before proceeding with migration.',
});
}
} catch (err: any) {
if (err instanceof AmplifyError) throw err;
if (!err.message?.includes('no upstream') && !err.stderr?.includes('no upstream')) {
throw err;
}
}
}

public async validateDeploymentStatus(): Promise<void> {
Expand Down
Loading