feat: add flag to disable gsi limit check in iterative deployments #13172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
force-pushed
the
disable-gsi-limit-check
branch
from
00305a8
to
c2691c6
Compare
AaronZyLee
previously approved these changes
Sep 1, 2023
phani-srikar
previously approved these changes
Sep 1, 2023
edwardfoyle
reviewed
Sep 6, 2023
...-provider-awscloudformation/src/graphql-resource-manager/amplify-graphql-resource-manager.ts
Outdated
Show resolved
Hide resolved
alharris-at
dismissed stale reviews from phani-srikar and AaronZyLee
via
b46178a
alharris-at
force-pushed
the
disable-gsi-limit-check
branch
from
c2691c6
to
b46178a
Compare
phani-srikar
approved these changes
Sep 6, 2023
edwardfoyle
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding a new flag to support overriding DynamoDB GSI limits for customers with limit increases in dynamodb. Also fix printing the name since in general it's not a string, but a
Refobject.By executing
amplify push --disable-gsi-limit-checkthe limit checks will be disabled.Relevant docs update: aws-amplify/docs#5836
Issue #, if available
aws-amplify/amplify-category-api#1812
Description of how you validated changes
Unit Tests, and ran w/ a
setup-devtarget, with a stubbed out low value.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.