Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds code for showing service event info when using ecs deploy controller #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipem1210
Copy link

@felipem1210 felipem1210 commented Feb 5, 2023

Issue #, if available: #447

Description of changes:

  • Added the new input show-service-events to enable the routine
  • The routine will call describe-ecs-service each amount of seconds seconds to check how is the rolloutState of the deployment.
  • If it is FAILED or IN_PROGRESS but with failedTasksCount more than 0, will detect that the deployment didn't go well, will show the latest events and throw error.
  • If there is a task failed, show the stop reason of the task
  • If it is COMPLETED keep going.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@felipem1210 felipem1210 force-pushed the feat/show-service-events branch 2 times, most recently from 8b66948 to 91af23e Compare February 6, 2023 14:50
@amazreech
Copy link
Contributor

Hi @felipem1210,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review.

In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.

  2. Resolve any conflicts on the PR

  3. Please run npm run package command to update dist/ folder with latest dependencies.

index.test.js Outdated

mockEcsDescribeServices.mockImplementation(() => {
return {
promise() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mock needs to be updated as the action is now using JS SDK v3

Refer: #529

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr I could resolve the conflicts but the tests I implemented are failing, can I have some guidance on how should I correct them? I am more a cloud engineer than a javascript developer, so I am noob where talking about testing code

Copy link
Contributor

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided diff for transforming JS SDK v2 APIs to v3.

Refs: #529

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants