-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds code for showing service event info when using ecs deploy controller #454
base: master
Are you sure you want to change the base?
feat: adds code for showing service event info when using ecs deploy controller #454
Conversation
8b66948
to
91af23e
Compare
Hi @felipem1210, Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. We will reach-out if with any questions or suggestions during the review. In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:
|
index.test.js
Outdated
|
||
mockEcsDescribeServices.mockImplementation(() => { | ||
return { | ||
promise() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mock needs to be updated as the action is now using JS SDK v3
Refer: #529
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trivikr I could resolve the conflicts but the tests I implemented are failing, can I have some guidance on how should I correct them? I am more a cloud engineer than a javascript developer, so I am noob where talking about testing code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided diff for transforming JS SDK v2 APIs to v3.
Refs: #529
91af23e
to
61fc2fd
Compare
61fc2fd
to
bf5bcb3
Compare
Issue #, if available: #447
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.