Send the Origin, not X-Forwarded-Host, HTTP header with API requests #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the WP101 Plugin app, we need to know what domain the plugin is running on so that we may ensure the correct videos are getting served. For the longest time, we've been using `X-Forwarded-Host`, but this header will get overwritten on systems leveraging any sort of load balancer or other proxy. The **proper** header in this case is `Origin`. [From MDN](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin): > The `Origin` request header indicates the origin (scheme, hostname, and port) that caused the request. For example, if a user agent needs to request resources included in a page, or fetched by scripts that it executes, then the origin of the page may be included in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the WP101 Plugin app, we need to know what domain the plugin is running on so that we may ensure the correct videos are getting served.
For the longest time, we've been using
X-Forwarded-Host, but this header will get overwritten on systems leveraging any sort of load balancer or other proxy. The proper header in this case isOrigin. From MDN: