Use table alias/name when building date query #9700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue described in #9699
Use the received table name & table alias arguments in the
get_sql
function to set those as properties on the Date class. Note thatget_sql
already gets called with those params as per the line below. However theget_sql
function oddly wasn't defining those arguments in its definition.easy-digital-downloads/includes/database/engine/class-query.php
Line 1363 in 715373d
Then, when building the SQL query, use the alias or name (only if available) to prepend to the column name in the query. This prevents ambiguity issues when performing the SQL query
This prevents and fixes the issue described in #9699
I am open to receiving feedback on the solution proposed and working on an updated solution.
Thanks!