Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added anki-sync.yml #1027

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dacid99
Copy link

@Dacid99 Dacid99 commented Dec 20, 2024

Added the dockerized version of anki-sync server

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

Added the dockerized version of anki-sync server
@Ki-er Ki-er added addition Adding new software to the list reviewers wanted Awaiting reviews labels Dec 20, 2024
Copy link
Collaborator

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good too if you could clean up the docs and add a example Docker command people can use.

tags:
- Learning and Courses
- Knowledge Management Tools
depends_3rdparty: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional so can be removed

Suggested change
depends_3rdparty: false

Comment on lines +7 to +10
platforms:
- Rust
- Python
- Docker
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms:
- Rust
- Python
- Docker
platforms:
- Docker

@nodiscc
Copy link
Member

nodiscc commented Dec 28, 2024

Hi @Dacid99

I will copy-paste here the comment I made on #33 (comment)

How do we handle software contributions that merely port an existing application to another system (e.g., Dockerization)

I don't think we should approve these, it will open the gates to a flood of custom builds, third-party docker images... a quick search returns at least 2 other docker image projects for Anki [1] [2], so I'd prefer if these solutions could be considered first:

  • contributing the OCI image build procedure to the upstream project (Dockerfile, documentation)... Anki devs were apparently open to contributions in the issue linked above
  • linking to the third-party docker image build from the upstream's project documentation

Have you tried to get Docker support added directly into the upstream project (Anki)?

@nodiscc nodiscc added discussion General discussion feedback needed Awaiting feedback/changes by the submitter labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list discussion General discussion feedback needed Awaiting feedback/changes by the submitter reviewers wanted Awaiting reviews
Development

Successfully merging this pull request may close these issues.

3 participants