minor changes in security vunerable part of sharedpreferences by adding encryption #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its good to see that you have added encryption to the shared preferences but deploying this to the existing user will give weird behavior to the app as the data previously stored are not encrypted. |
awazgyawali
reviewed
Sep 15, 2018
| } | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
oh :D i was just saving incase someone needs that in php
wisdomrider
commented
Sep 15, 2018
There was a problem hiding this comment.
Its good to see that you have added encryption to the shared preferences but deploying this to the existing user will give weird behavior to the app as the data previously stored are not encrypted.
yup bro you have to clear the exisiting preferences data to use this one .
| } | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
oh :D i was just saving incase someone needs that in php
|
done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor changes in security vunerable part of sharedpreferences by adding encryption