Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qdevices: Adapt virtiofsd options #3985

Merged
merged 1 commit into from
Sep 12, 2024
Merged

qdevices: Adapt virtiofsd options #3985

merged 1 commit into from
Sep 12, 2024

Conversation

hellohellenmao
Copy link
Contributor

Some options are deprecated since the dedicated virtiofsd package since rhel9, while before virtiofsd belongs to qemu package.

@hellohellenmao
Copy link
Contributor Author

@luckyh @YongxueHong Could you please help to take a review here? Thanks.

@hellohellenmao
Copy link
Contributor Author

The most basic case passed on both old version and new version.
Old version:
(2/2) Host_RHEL.m9.u2.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.2.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data.with_cache.auto.q35: PASS (67.54 s)
New version:
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data.with_cache.auto.q35: PASS (66.26 s)

@hellohellenmao
Copy link
Contributor Author

@luckyh Could you please help to take a review here? thanks.

@hellohellenmao
qdevices: Adapt virtiofsd options
074c2e2 
Some options are deprecated since the dedicated virtiofsd package
since rhel9, while before virtiofsd belongs to qemu package.

Signed-off-by: Tingting Mao <[email protected]>
@hellohellenmao
Copy link
Contributor Author

@YongxueHong Could you please help to review here? Thanks.

@hellohellenmao
Copy link
Contributor Author

The basic caset passed with the latest code:
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data.with_cache.auto.q35: PASS (66.17 s)

luckyh
luckyh approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@luckyh luckyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YongxueHong
YongxueHong approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YongxueHong YongxueHong merged commit bf03c82 into avocado-framework:master Sep 12, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YongxueHong YongxueHong YongxueHong approved these changes

@luckyh luckyh luckyh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellohellenmao @luckyh @YongxueHong