#754 | Implementer friendliness for avni #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himeshr
requested changes
Sep 17, 2024
There was a problem hiding this comment.
1. In General, we would like the MetadataDiffService to be further modularized.
Ideally break it into following mini services:
- MetadataBundleAndFileHandler : To take care of unzip, read files only
- MetadataDiffChecker: To identify differences
- MetadataDiffOutputGenerator: to create diff objects of various types
- etc.. additional ones as need
2. Also, breakdown large methods into smaller methods with appropriate names to make the code more readable.
3. Replace all string literals with String constants
himeshr
requested changes
Sep 19, 2024
himeshr
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the difference between two zip file which contains json form.
How it Works