allow to leave missing signatures as null #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps backend do partial signatures in the right places
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
jszmltr
reviewed
Dec 3, 2024
| internal fun List<AccountMeta>.normalize(): List<AccountMeta> = groupBy { it.publicKey } | ||
| import net.avianlabs.solana.tweetnacl.ed25519.PublicKey | ||
|
|
||
| internal fun List<AccountMeta>.normalize( |
There was a problem hiding this comment.
would it make sense to have two separate functions ?
normalize() and normalizeWithFeePayer ?
There was a problem hiding this comment.
no, fee payer might be set or not
jszmltr
approved these changes
Dec 3, 2024
| logger.warn { "Duplicate signatures detected" } | ||
| val signatures = signers.associate { signer -> | ||
| signer.publicKey to | ||
| TweetNaCl.Signature.sign(serializedMessage, signer.secretKey) |
There was a problem hiding this comment.
so the signatures can preserve the order of account meta list
wiyarmir
deleted the
guillermo/allow-to-leave-missing-signatures-as-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this helps backend do partial signatures in the right places
we also ensure fee payer stays at the top