make secretbox methods return nullable #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this matches the actual api contract of the underlying tweetnacl java implementation
jszmltr
approved these changes
Jul 18, 2024
| TweetNaclFast.SecretBox(secretKey).box(message, nonce) | ||
|
|
||
| override fun open(box: ByteArray, nonce: ByteArray): ByteArray = | ||
| override fun open(box: ByteArray, nonce: ByteArray): ByteArray? = | ||
| TweetNaclFast.SecretBox(secretKey).open(box, nonce) |
There was a problem hiding this comment.
Doesn't this throw instead of returning null ?
There was a problem hiding this comment.
Maybe we can runCatching getOrNull here ?
There was a problem hiding this comment.
Ideally with some logger 👀 :¯_(ツ)_/¯
There was a problem hiding this comment.
Ah ok. It was throwing nullpointer exception with the result being null 👍
There was a problem hiding this comment.
sorry the nope was at the throw comment 😂
There was a problem hiding this comment.
this is a library, I think the functionality should be minimal. I'm doing all those things in the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this matches the actual api contract of the underlying tweetnacl java implementation