-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spiritor ai #5323
base: main
Are you sure you want to change the base?
added spiritor ai #5323
Conversation
Your project is too new, it's only been 4 days. I don't think it is stable enough. Please resubmit once you write tests, and it reaches a stable 1.0 |
@phanirithvij Seriously? There's a ton of packages on your list that are still in v0.x.x. Being in v1.x.x isn't even a requirement in any of your docs. I may have only published this a few days ago but it's been around for a while. Lame. |
Sorry I shouldn't have closed it. I know there are bad entries, cleaning up is not easy. It's not possible to automate cleaning up properly. I will remove those entries. There is a requirement in the contributing guide in the quality standards
But sure it's not exactly v1.0.0. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@phanirithvij Go's own documentation states that a project is stable once it has reached v1.0.0. Maybe worth pointing out in the guidelines. |
@k-capehart thank you. I remember seeing it somewhere but forgot where. |
What does this mean Sent from my iPhoneOn Jun 19, 2024, at 11:46 AM, Kyle Capehart ***@***.***> wrote:
@phanirithvij Go's own documentation states that a project is stable once it has reached v1.0.0. Maybe worth pointing out in the guidelines.
image.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Developer Comments
Hey there. I am the developer/maintainer for this library. I just wanted to note that I do not have CI and/or unit testing running yet (hence the unchecked boxes below) but plan to in the future. This is challenging though, because this app is primarily a CLI that reads/writes from the local filesystem and building unit tests is a challenge. I need to research and figure out the best testing strategy for a package like this and that will be happening as the project progresses.
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 😎
Summary by CodeRabbit