Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smart-home to the IoT category #5237

Merged
merged 2 commits into from
Jun 28, 2024
Merged

add smart-home to the IoT category #5237

merged 2 commits into from
Jun 28, 2024

Conversation

e154
Copy link
Contributor

@e154 e154 commented Mar 10, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 馃槑

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All the files appear to be documentation files, which we're not great at reviewing... yet!

Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@riccardopinosio
Copy link
Contributor

@e154 I think you're missing the full stop "." at the end of the added line

@e154
Copy link
Contributor Author

e154 commented Mar 12, 2024

@e154 I think you're missing the full stop "." at the end of the added line

thanks for the note, fixed it

@phanirithvij
Copy link
Collaborator

Is it not possible to improve the code coverage or atleast have e2e tests? I can think of having a self-hosted github actions runner and do integration tests (test all features basically) or do you have something similar like a test rig? If so I don't mind the low code coverage.

@kalapee

This comment was marked as spam.

@e154
Copy link
Contributor Author

e154 commented Jun 28, 2024

In the application, important parts of the functional code are covered by unit tests and e2e tests in the test directories. I test the rest of the parts locally. I won鈥檛 be able to fully cover it with automated tests, because the application is very large and I don鈥檛 have enough effort and resources. Hopefully this will improve over time as the app's community of users expands and more helpers appear.

@phanirithvij phanirithvij merged commit dcc5e18 into avelino:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants