-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add smart-home to the IoT category #5237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. All the files appear to be documentation files, which we're not great at reviewing... yet!
Thank you for contributing to awesome-go. We will review your contribution as soon as possible. Make sure you add the links in the body of the pull request that are requested in the contribution guide:
|
@e154 I think you're missing the full stop "." at the end of the added line |
thanks for the note, fixed it |
Is it not possible to improve the code coverage or atleast have e2e tests? I can think of having a self-hosted github actions runner and do integration tests (test all features basically) or do you have something similar like a test rig? If so I don't mind the low code coverage. |
This comment was marked as spam.
This comment was marked as spam.
In the application, important parts of the functional code are covered by unit tests and e2e tests in the test directories. I test the rest of the parts locally. I won鈥檛 be able to fully cover it with automated tests, because the application is very large and I don鈥檛 have enough effort and resources. Hopefully this will improve over time as the app's community of users expands and more helpers appear. |
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 馃槑