Do not try to check min_perl_version during prereq registration #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to $self->min_perl_version in the default sub for eumm_version would
be unlikely to get something correct. This is because eumm_version ends up
being called during prereq registration. That means that whatever plugin might
set a perl version prereq may not have run yet.
The symptom of this is you end up losing the min_perl_version bits in the
generated Makefile.PL, because min_perl_version is called too early and ends
up being set to an empty string.
Specifically, I saw this with a number of distro where I have a line like "use
5.0100" in the code and I'm using AutoPrereqs.