Skip to content

Conversation

@abankhele
Copy link
Contributor

Created cypress test cases for high priority.

@abankhele abankhele requested a review from cjcolvar November 5, 2025 17:16
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

id: field_id,
class: "form-control typeahead-input",
data: data,
data: { testid: "autocomplete-user-input" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be generic?

Suggested change
data: { testid: "autocomplete-user-input" },
data: { testid: "#{for_field}-user-input" },

disabled: disabled,
placeholder: placeholder %>
<ul class='autocomplete_popup' id=<%= "#{for_field}-popup" %>></ul>
<ul class='autocomplete_popup' data-testid="user-popup" id=<%= "#{for_field}-popup" %>></ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be generic?

Suggested change
<ul class='autocomplete_popup' data-testid="user-popup" id=<%= "#{for_field}-popup" %>></ul>
<ul class='autocomplete_popup' data-testid="#{for_field}-popup" id=<%= "#{for_field}-popup" %>></ul>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants