7.7.1 RC2 #5767
Merged
7.7.1 RC2 #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRT formatted captions are converted to VTT format when the content is requested by Ramp. However, the iiif manifest still had the format for these files listed as 'text/srt'. This caused Ramp to not process the file correctly and the caption file would not show up in the subs/captions list in the player. Setting the format to 'text/vtt' allows Ramp to correctly process the caption track.
Serialize captions to IIIF manifest with text/vtt as the format
joncameron
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of bug fix #5766 in develop to staging for testing before release to 7.7.1