Skip to content

Commit

Permalink
Fix a11y color contrast for SCSS variable in branding
Browse files Browse the repository at this point in the history
  • Loading branch information
Dananji authored and cjcolvar committed Apr 26, 2024
1 parent ddd23ad commit 3832fb1
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
15 changes: 10 additions & 5 deletions app/assets/stylesheets/blacklight.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@

@import 'blacklight/blacklight';

.result-thumbnail img, img.result-thumbnail {
.result-thumbnail img,
img.result-thumbnail {
max-width: 160px;
}

.no-icon img, img.no-icon {
.no-icon img,
img.no-icon {
max-height: 90px;
}

Expand All @@ -31,7 +33,8 @@
@extend .btn-outline;
}

#sort-dropdown, #per_page-dropdown {
#sort-dropdown,
#per_page-dropdown {
.dropdown-item.active {
color: $dark;
background-color: $white;
Expand All @@ -44,7 +47,9 @@

// Access control update modal form in Bookmarks
#update_access_control_form {
.item-discovery, .item-access, .special-access {
.item-discovery,
.item-access,
.special-access {
legend {
border-bottom: 1px solid #e5e5e5;
}
Expand All @@ -55,7 +60,7 @@
// Needed to override btn-secondary-outline
.applied-filter .remove:hover {
color: white !important;
background-color: #f44336 !important;
background-color: #d14242 !important;
}

.page-item span.page-link {
Expand Down
5 changes: 2 additions & 3 deletions app/assets/stylesheets/branding.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ $lightblue: #31708f;
$info: #fbb040;
$success: #429453;
$warning: #bf841b;
$danger: #f44336;
$danger: #d14242;

/**
* Bootstrap variable overrides
Expand Down Expand Up @@ -118,8 +118,7 @@ $navbar-light-toggle-border-color: $white;
// Inverted navbar toggle
$navbar-inverse-toggle-hover-bg: #e6e6e6;
$navbar-inverse-toggle-icon-bar-bg: $lightgray;
$navbar-inverse-toggle-border-color: rgba(0, 0, 0, 0.1) rgba(0, 0, 0, 0.1)
rgba(0, 0, 0, 0.25);
$navbar-inverse-toggle-border-color: rgba(0, 0, 0, 0.1) rgba(0, 0, 0, 0.1) rgba(0, 0, 0, 0.25);

$grid-gutter-width: 16px;

Expand Down

0 comments on commit 3832fb1

Please sign in to comment.