Skip to content

Commit

Permalink
Merge pull request #5560 from avalonmediasystem/collection_landing_we…
Browse files Browse the repository at this point in the history
…bsite

Only return link html if website url present
  • Loading branch information
Dananji authored Jan 10, 2024
2 parents e5e6b74 + 48c297a commit 3179f31
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/presenters/collection_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def contact_email
end

def website_link
view_context.link_to document["website_label_ssi"], document["website_url_ssi"] unless document["website_url_ssi"].nil?
view_context.link_to document["website_label_ssi"], document["website_url_ssi"] if document["website_url_ssi"].present?
end

def as_json(_)
Expand Down
8 changes: 8 additions & 0 deletions spec/presenters/collection_presenter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@
expect(presenter.website_link).to be_nil
end
end

context 'with a blank website url' do
let(:website_url) { '' }

it 'returns null' do
expect(presenter.website_link).to be_nil
end
end
end

describe '#as_json' do
Expand Down

0 comments on commit 3179f31

Please sign in to comment.