Add HttpStatus enum for status code #263
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal in the sense that it has the
__not_set(0)
entry. The default status codes depend on the HTTP method + if the return body is empty (void methods).An alternative is to have a separate annotation like
@Status
or@ResponseStatus
and remove the statusCode attributes from@Produces
and@ExceptionHandler
(and then the __not_set entry could be remove from the HttpStatus enum).Also not ideal in that this PR just copies the enum for the generator.