Merge pull request #287 from avaje/feature/BigInteger

#285 BigInteger support for path parameter
avaje · Sep 13, 2023 · cc7d5ce · cc7d5ce
2 parents 29e8f15 + 597bc6e
commit cc7d5ce
Show file tree

Hide file tree

Showing 6 changed files with 61 additions and 2 deletions.
diff --git a/http-generator-core/src/main/java/io/avaje/http/generator/core/TypeMap.java b/http-generator-core/src/main/java/io/avaje/http/generator/core/TypeMap.java
@@ -34,7 +34,7 @@ private static void add(TypeHandler h) {
 
     add(new UuidHandler());
     add(new BigDecimalHandler());
-    add(new BigDecimalHandler());
+    add(new BigIntegerHandler());
     add(new LocalDateHandler());
     add(new LocalTimeHandler());
     add(new LocalDateTimeHandler());

diff --git a/http-generator-core/src/test/java/io/avaje/http/generator/core/TypeMapTest.java b/http-generator-core/src/test/java/io/avaje/http/generator/core/TypeMapTest.java
@@ -53,4 +53,20 @@ void get_Float() {
     assertThat(handler.asMethod()).isEqualTo("asFloat(");
     assertFalse(handler.isPrimitive());
   }
+
+  @Test
+  void get_BigDecimal() {
+    TypeHandler handler = TypeMap.get("java.math.BigDecimal");
+    assertThat(handler).isInstanceOf(TypeMap.BigDecimalHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asBigDecimal(");
+    assertFalse(handler.isPrimitive());
+  }
+
+  @Test
+  void get_BigInt() {
+    TypeHandler handler = TypeMap.get("java.math.BigInteger");
+    assertThat(handler).isInstanceOf(TypeMap.BigIntegerHandler.class);
+    assertThat(handler.asMethod()).isEqualTo("asBigInteger(");
+    assertFalse(handler.isPrimitive());
+  }
 }
diff --git a/tests/test-javalin-jsonb/src/main/resources/public/openapi.json b/tests/test-javalin-jsonb/src/main/resources/public/openapi.json
@@ -1,7 +1,7 @@
 {
 	"openapi" : "3.0.1",
 	"info" : {
-		"title" : "Example service showing off the Path extension method of controller",
+		"title" : "Example service",
 		"description" : "Example Javalin controllers with Java and Maven",
 		"version" : ""
 	},

diff --git a/tests/test-jex/src/main/java/org/example/web/HelloController.java b/tests/test-jex/src/main/java/org/example/web/HelloController.java
@@ -9,6 +9,8 @@
 import io.avaje.http.api.Valid;
 import io.avaje.jex.Context;
 
+import java.math.BigInteger;
+
 // @Roles(AppRoles.BASIC_USER)
 @Controller
 @Path("/")
@@ -58,4 +60,9 @@ String splat2(String name, String nam0, String nam1) {
   void put(HelloDto dto) {
     dto.hashCode();
   }
+
+  @Get("/bigInt/{val}")
+  String testBigInt(BigInteger val) {
+    return "hi|" + val;
+  }
 }
diff --git a/tests/test-jex/src/main/resources/public/openapi.json b/tests/test-jex/src/main/resources/public/openapi.json
@@ -48,6 +48,37 @@
 				}
 			}
 		},
+		"/bigInt/{val}" : {
+			"get" : {
+				"tags" : [
+
+				],
+				"summary" : "",
+				"description" : "",
+				"parameters" : [
+					{
+						"name" : "val",
+						"in" : "path",
+						"required" : true,
+						"schema" : {
+							"type" : "number"
+						}
+					}
+				],
+				"responses" : {
+					"200" : {
+						"description" : "",
+						"content" : {
+							"application/json" : {
+								"schema" : {
+									"type" : "string"
+								}
+							}
+						}
+					}
+				}
+			}
+		},
 		"/other/{name}" : {
 			"get" : {
 				"tags" : [

diff --git a/tests/test-nima-jsonb/src/main/java/org/example/HelloController.java b/tests/test-nima-jsonb/src/main/java/org/example/HelloController.java
@@ -148,4 +148,9 @@ String form(String name, String email, String url) {
   String formBean(MyForm form) {
     return form.name + "|" + form.email + "|" + form.url;
   }
+
+//  @Get("/bigInt/{val}")
+//  String testBigInt(BigInteger val) {
+//    return "hi|" + val;
+//  }
 }