Only check abi go bindings for diff #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
| @@ -39,7 +39,10 @@ jobs: | |||
| ./scripts/abi_bindings.sh | |||
|
|
|||
| - name: Check for clean branch | |||
| run: .github/workflows/check_clean_branch.sh | |||
| run: | | |||
| git --no-pager diff -- abi-bindings/**.go | |||
There was a problem hiding this comment.
can you add the comments you have in PR description for these commands
There was a problem hiding this comment.
Split into two steps and named them by what they're doing
cam-schultz
approved these changes
Oct 26, 2023
minghinmatthewlam
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes failing abi check for dependabot branches.
How this works
Dependabot branches were failing this check because they do not update
go.work.sum. This was causing the global diff to always fail. This check should only check if any of our Go ABI bindings have changes and not been commited.This only checks diffs for files that match
abi-bindings/**.gogit --no-pager diffwill print the diffgit --no-pager diff --quietwill return a failed exit code if there is a diffI tried adding a step for dependabot to commit the changes to
go.work.sum, but this results in an unverified commit.How this was tested
I've updated
gomegain the PR to show that this change eliminates the false-positives.How is this documented