Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators can remove Delegators #602

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

cam-schultz
Copy link
Contributor

Why this should be merged

Fixes #569

How this works

Allows the validation owner to call initializeEndDelegation as long as the minimum stake duration has elapsed.

How this was tested

CI, added unit tests

How is this documented

Updates the README with Validator and Delegator owner role descriptions.

Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we might want to add another utility function that's callable by validation owner only to end all valid delegations but that's out of scope for this certainly and might be too much of a complication for the minor UX improvement

Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geoff-vball
Copy link
Contributor

@iansuvak That would also require keeping a list... Which we might want to do, but adds a lot of complication and overhead.

@cam-schultz cam-schultz merged commit 8af29c8 into validator-manager Oct 16, 2024
14 checks passed
@cam-schultz cam-schultz deleted the vdrs-can-remove-dlgrs branch October 16, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants