Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cleanup #576

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Test cleanup #576

merged 2 commits into from
Sep 26, 2024

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Sep 26, 2024 •
edited
Loading

Why this should be merged

  • Adds context to all the validator manager function calls to be passed through.
  • Renames all instances of sendingKey to senderKey which we had been using previously.

@geoff-vball geoff-vball marked this pull request as ready for review September 26, 2024 15:56
@geoff-vball geoff-vball requested a review from a team as a code owner September 26, 2024 15:56
@geoff-vball geoff-vball merged commit 32c5f81 into validator-manager Sep 26, 2024
12 checks passed
@iansuvak iansuvak mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansuvak iansuvak iansuvak approved these changes

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@minghinmatthewlam minghinmatthewlam Awaiting requested review from minghinmatthewlam minghinmatthewlam is a code owner automatically assigned from ava-labs/interop

@bernard-avalabs bernard-avalabs Awaiting requested review from bernard-avalabs bernard-avalabs is a code owner automatically assigned from ava-labs/interop

@cam-schultz cam-schultz Awaiting requested review from cam-schultz cam-schultz is a code owner automatically assigned from ava-labs/interop

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoff-vball @iansuvak @michaelkaplan13