Unit test cleanup #574
Merged
Unit test cleanup #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
unit-test-cleanup
branch
from
c4fec2b
to
81edf43
Compare
geoff-vball
requested review from
iansuvak,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
cam-schultz
approved these changes
Sep 25, 2024
| return delegationID; | ||
| } | ||
|
|
||
| function _setUpInitializeEndDelegation( | ||
| function _initializeEndDelegationValidatorActiveWithChecks( |
There was a problem hiding this comment.
Is there a specific use case you have in mind that would be better served by having separate WithChecks functions? It looks like the functions without the checks are not called directly anywhere else.
There was a problem hiding this comment.
If you expect the code to revert somewhere inside of _initializeEndDelegationValidatorActive, you can call vm.expectRevert before calling it. If you used _initializeEndDelegationValidatorActiveWithChecks in the same situation, your test would probably fail because it failed to emit an event that it was expecting, due to the early revert.
minghinmatthewlam
approved these changes
Sep 25, 2024
iansuvak
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Refactors a lot of our testing code. Simplifies creating the first validator and delegator for tests that should start out with them.
How this works
How this was tested
Existing tests
How is this documented