Staking rename -> validator manager #558
Conversation
iansuvak
requested review from
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
| @@ -6,8 +6,8 @@ import ( | |||
|
|
|||
| "github.com/ava-labs/avalanchego/ids" | |||
| "github.com/ava-labs/subnet-evm/accounts/abi/bind" | |||
| nativetokenstakingmanager "github.com/ava-labs/teleporter/abi-bindings/go/staking/NativeTokenStakingManager" | |||
There was a problem hiding this comment.
I think similar to the contracts, this test folder should be renamed to validatormanager, same with the pkg name
tests/utils/staking.go
Outdated
| examplerewardcalculator "github.com/ava-labs/teleporter/abi-bindings/go/staking/ExampleRewardCalculator" | ||
| nativetokenstakingmanager "github.com/ava-labs/teleporter/abi-bindings/go/staking/NativeTokenStakingManager" | ||
| poavalidatormanager "github.com/ava-labs/teleporter/abi-bindings/go/staking/PoAValidatorManager" | ||
| erc20tokenstakingmanager "github.com/ava-labs/teleporter/abi-bindings/go/validatorManager/ERC20TokenStakingManager" |
There was a problem hiding this comment.
this utils can also be renamed to validator manager
|
Honestly not sure if we have a standard here or not yet...but what do people prefer between |
https://github.com/ava-labs/awm-relayer/tree/main/signature-aggregator |
I agree I will make the change |
Why this should be merged
Closes #545
How this works
How this was tested
based off of staking-rewards so once those tests are fixed these should pass as well
How is this documented