Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove tesnet flows #498

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

minghinmatthewlam
Copy link

Why this should be merged

Removes testnet e2e flows that we don't use and is extra burden to maintain. Mostly will rely on local network e2e tests, only main difference with testing on testnet is the difference in the networks, so confirming in manual deployments of Teleporter's interaction with Warp and network validators should cover

How this works

still leaves e2e test that allow for non local networks being passed. Might be useful when we want to manually set up testnet testing.

How this was tested

How is this documented

Copy link
Contributor

@geoff-vball geoff-vball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the upload tmpnet files step just needs to be fixed

tests/network.go Outdated Show resolved Hide resolved
@minghinmatthewlam minghinmatthewlam changed the title Remove tesnet flows [WIP] Remove tesnet flows Aug 22, 2024
@minghinmatthewlam minghinmatthewlam marked this pull request as draft August 22, 2024 17:55
@minghinmatthewlam
Copy link
Author

deferring for now to fully handle removing #498 (comment)

@geoff-vball geoff-vball marked this pull request as ready for review October 9, 2024 18:25
Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplification with removal of interfaces and resulting shrinking of the utils file.

FWIW I didn't mind the earlier commit you had with n instead of localnetwork either but this works too.

Copy link
Contributor

@cam-schultz cam-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just one request to put the LocalNetwork methods all in the same place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the LocalNetwork methods in this file to tests/network/network.go with all the others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

6 participants