sync: coreth PR #1203: style: enable errcheck linter #1876
+73
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Oppenheimer <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
JonathanOppenheimer
changed the title
| for i := range nodes { | ||
| node := tmpnet.NewNode() | ||
| node.EnsureKeys() | ||
| _ = node.EnsureKeys() |
Member
There was a problem hiding this comment.
Can you add a comment why this is safe? (similar to core/fifo_cache.go)
Comment on lines
+181
to
+182
| _, _ = rand.Read(key) | ||
| _, _ = rand.Read(value) |
Member
There was a problem hiding this comment.
Can you add a comment why this is safe? (similar to core/fifo_cache.go)
JonathanOppenheimer
approved these changes
Dec 1, 2025
Member
JonathanOppenheimer
left a comment
JonathanOppenheimer
left a comment
There was a problem hiding this comment.
I compared this side by side to the coreth PR -- all looks good to me. I left two comments just to understand why we can ignore a couple of the errors.
12 tasks
ceyonur
approved these changes
Dec 2, 2025
Collaborator
ceyonur
left a comment
ceyonur
left a comment
There was a problem hiding this comment.
overall lgtm just two places can be used with t.Cleanup
Comment on lines
+2722
to
+2724
| defer func() { | ||
| require.NoError(t, vm.Shutdown(t.Context())) | ||
| }() |
Comment on lines
+3538
to
+3540
| defer func() { | ||
| require.NoError(t, vm.Shutdown(ctx)) | ||
| }() |
Collaborator
There was a problem hiding this comment.
again should this be t.Cleanup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds a required linter for avalanchego merge.
How this works
"Cherry-picks" ava-labs/coreth#1203. There were a lot of conflicts though, so most of it was done by hand
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No