chore: workflow to print diffs vs libevm-base tag
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Provides an objective measure of the diff against geth.
How this works
--diff-filter=aexcludes additions (i.e. libevm-specific files), leaving only modifications, deletions, etc.--word-difffine-grained diff instead of per-line--unified=0removes context, which is noisy when viewing the diff as a wholeThe
libevm-basetag MUST now always track the geth version from which the current version of libevm diverges. This workflow performs a difflibevm-base..HEAD(i.e. diff if the PR is merged) andlibevm-base..libevm(i.e. the current status quo).In the future we can look at performing a "diff of diffs" and warn if a PR increases destructive changes. Basic [+x -y] stats could also be extracted.
How this was tested
Pain and suffering (look at the commit history).