Expose graph option for fwdctl #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dump was already dumping the keys and values, so we should keep that, but added in the option of calling the dump() method that produces a digraph of the trie. Additional changes: hashes and binary values are truncated to 6 characters, followed by an ellipsis, and the graphs are rotated so they go left-right. This makes the graphs a lot prettier. Partial paths can still be long but truncating them seemed like a bad idea, so they are the only long string in the boxes now.
rkuris
force-pushed
the
rkuris/fwdctl-graph-cmd
branch
from
31b976e
to
e8b71ba
Compare
CI should build with tracing enabled...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dump was already dumping the keys and values, so we should keep that, but added in the option of calling the dump() method that produces a digraph of the trie.
Additional changes: hashes and binary values are truncated to 6 characters, followed by an ellipsis, and the graphs are rotated so they go left-right. This makes the graphs a lot prettier.
Partial paths can still be long but truncating them seemed like a bad idea, so they are the only long string in the boxes now.