refactor HashedNodeStore.hash
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuris
approved these changes
Jul 10, 2024
| // We found a branch, so find all the children that need hashing | ||
| let mut modified = false; | ||
| ) -> Result<(TrieHash, LinearAddress), Error> { | ||
| let modified = self.added.remove(&node_addr); |
There was a problem hiding this comment.
nit: I think this was easier to read with the external function that isolated the magic about into_inner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression. I also think this simplifies the code.
addedis a better name thanmodified.The updated
hashimplementation now handles changed node sizes, which it couldn't before. This is sort of a hack because we shouldn't ever need to increase the size allocated to a branch node once we know the number of children. That is, a branch node with moreAddressWithHashchildren has a larger serialized representation than the same node with onlyAddresschildren. This can be addressed in a follow up PR.