Rkuris/no wal #677
Closed
Rkuris/no wal #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a NodeStore and a LinearStore. Both are far from complete.
Checkpoint: - Renamed ReadOnlyLinearStore to ReadLinearStore since ReadWriteLinearStore must also implement it - Renamed ReadWriteLinearStore to WriteLinearStore since all writeable linear stores must implement ReadLinearStore - Required NodeStore to have a ReadLinearStore type of LinearStore. This was necessary because we had to call the stream_from method - The LayeredReader now compiles but needs more work
- Moved the size method to ReadLinearStore and implemented it in a few places - Added a test ConstBacked which is kind of like a file but has a constant string in it - Wrote a very nieve implementation of write for Proposal - Wrote some smoke tests for proposal
Renamed all "part" and "region" to "area" per online conversations Implemented partial reads Added nested test
Also introduced a few dyn to avoid the infinite nesting of types
…/firewood into rkuris/new-node-store-interface
Added lots of test cases
…/firewood into rkuris/new-node-store-interface
Still some TODOs but this gets it started breaks node.rs
This reverts commit 3a5a6c1.
… into remove-shale
Co-authored-by: Ron Kuris <[email protected]>
Co-authored-by: Ron Kuris <[email protected]>
|
Everything from this branch was merged into Dan's branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.