Cargo cleanup #667
Merged
Cargo cleanup #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can almost eliminate serde, but there are some metrics packages using it, so it stays for now.
rkuris
force-pushed
the
rkuris/cargo-cleanup
branch
from
dc94e6b
to
36029d1
Compare
iFrostizz
suggested changes
Jun 12, 2024
There was a problem hiding this comment.
There are some unused dependencies left. You can run cargo machete to list them automatically, though there is a false positive for serde and prost.
diff --git a/grpc-testtool/Cargo.toml b/grpc-testtool/Cargo.toml
index f7a22fe..24843f6 100644
--- a/grpc-testtool/Cargo.toml
+++ b/grpc-testtool/Cargo.toml
@@ -18,12 +18,10 @@ bench = false
[dependencies]
firewood = { version = "0.0.4", path = "../firewood" }
prost = "0.12.3"
-thiserror = "1.0.57"
tokio = { version = "1.36.0", features = ["sync", "rt-multi-thread"] }
tonic = { version = "0.11.0", features = ["tls"] }
tracing = { version = "0.1.40" }
clap = { version = "4.5.0", features = ["derive"] }
-tempdir = "0.3.7"
log = "0.4.20"
env_logger = "0.11.2"
chrono = "0.4.34"
diff --git a/storage/Cargo.toml b/storage/Cargo.toml
index b4efac6..da7356e 100644
--- a/storage/Cargo.toml
+++ b/storage/Cargo.toml
@@ -13,8 +13,6 @@ hex = "0.4.3"
serde = { version = "1.0.199", features = ["derive"] }
smallvec = { version = "1.13.2", features = ["serde", "write", "union"] }
sha2 = "0.10.8"
-bytemuck = { version = "1.14.3", features = ["derive"] }
-integer-encoding = "4.0.0"
[dev-dependencies]
rand = "0.8.5"Leaving serde alone since I think we may be able to remove it
Great suggestion, thanks! I left serde alone because I think we might be able to remove it completely later. |
iFrostizz
approved these changes
Jun 12, 2024
| @@ -13,7 +13,7 @@ hex = "0.4.3" | |||
| serde = { version = "1.0.199", features = ["derive"] } | |||
| smallvec = { version = "1.13.2", features = ["serde", "write", "union"] } | |||
| sha2 = "0.10.8" | |||
| bytemuck = { version = "1.14.3", features = ["derive"] } | |||
| integer-encoding = "4.0.0" | |||
There was a problem hiding this comment.
Yeah, we'll need it very soon as the one user (hashednode.rs) will be moving to storage very soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unused dependencies from the main project.