Implement proof generation and verification #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
force-pushed
the
remove-shale-implement-proof
branch
from
9b1b45d
to
129a23e
Compare
danlaine
changed the title
added 5 commits
July 11, 2024 11:22
rkuris
requested changes
Jul 19, 2024
firewood/src/db.rs
Outdated
| @@ -79,7 +77,7 @@ impl<T: ReadLinearStore> api::DbView for HistoricalRev<T> { | |||
| async fn single_key_proof<K: api::KeyType>( | |||
| &self, | |||
| _key: K, | |||
| ) -> Result<Option<Proof<Vec<u8>>>, api::Error> { | |||
| ) -> Result<Option<Proof>, api::Error> { | |||
There was a problem hiding this comment.
Removing this generic means each ProofNode can be of a different type, which isn't what we want I think. All ProofNodes within a proof should either be owned or borrowed (currently all of them are borrowed).
I'd rather see the generic here and have ProofNode use the type from it's parent.
There was a problem hiding this comment.
The generic is added back in https://github.com/ava-labs/firewood/pull/682/files. I could merge that PR into this one if you want.
danlaine
changed the base branch from
remove-shale
to
remove-shale-refactor-merkle
rkuris
approved these changes
Jul 24, 2024
firewood/tests/db.rs
Outdated
| // TODO do type assertion on error | ||
| } | ||
| } | ||
| // #[ignore = "unimplemented"] |
There was a problem hiding this comment.
We should make sure this still compiles. Why was it commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a first pass on proof generation and verification. It:
ValueDigesttype to be genericPreimagetype. I couldn't figure out how to implement a blanket implementation forto_hashandwritewith the additional genericsVandH.Merkle.proveandProof.verify