Hash refactor #660
Merged
Hash refactor #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 23, 2024 16:28
rkuris
approved these changes
Jun 10, 2024
firewood/src/hashednode.rs
Outdated
| hasher.update([value_exists]); | ||
| return; | ||
| /// Returns the SHA-256 hash of the `preimage`. | ||
| pub(crate) fn _hash<K: Iterator<Item = u8> + Clone, V: AsRef<[u8]>>( |
There was a problem hiding this comment.
Why is this _hash instead of hash?
firewood/src/hashednode.rs
Outdated
| /// Returns the serialized representation of `node` used as the pre-image | ||
| /// when hashing the node. The node is at the given `path_prefix`. | ||
| pub fn hash_preimage(node: &Node, path_prefix: &Path) -> Box<[u8]> { | ||
| let mut buf = vec![]; |
There was a problem hiding this comment.
nit: Maybe vec::with_capacity(node.value.len()) or something to avoid reallocating the buffer every time.
There was a problem hiding this comment.
Changed to pre-allocate capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl HashedNodeStorebecause we don't actually use any of theHashedNodeStore's fields.HashPreimage. This generalizes the existing logic, which only knows how to hash a&Node. I think this will be useful in implementing proofs.hasherin instances where it's actually not necessarily a hasher (it could be a vec we're writing the node preimage into)