Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement merkle.remove #644

Merged
merged 77 commits into from
May 22, 2024
Merged

Implement merkle.remove #644

merged 77 commits into from
May 22, 2024

Commits on May 9, 2024

  1. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bb6c63c View commit details
    Browse the repository at this point in the history

  2. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f18ad1b View commit details
    Browse the repository at this point in the history

  3. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b3c377e View commit details
    Browse the repository at this point in the history

  4. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c244e84 View commit details
    Browse the repository at this point in the history

  5. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6a502aa View commit details
    Browse the repository at this point in the history

  6. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1d95fe9 View commit details
    Browse the repository at this point in the history

  7. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    73ceb2c View commit details
    Browse the repository at this point in the history

  8. WIP handle node movement upon update in insert

    Dan Laine committed May 9, 2024
    Configuration menu
    Copy the full SHA
    61cd68d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1d55548 View commit details
    Browse the repository at this point in the history

  2. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0b42b5b View commit details
    Browse the repository at this point in the history

  3. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8b9a734 View commit details
    Browse the repository at this point in the history

  4. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c8ac0d0 View commit details
    Browse the repository at this point in the history

  5. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e9b3f6f View commit details
    Browse the repository at this point in the history

  6. WIP handle node movement upon update in insert

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    040ee97 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7c39c59 View commit details
    Browse the repository at this point in the history

  8. merge

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5ff2ba2 View commit details
    Browse the repository at this point in the history

  9. make ancestors a DoubleEndedIterator so we don't have to rev() the tr… 

    …aversal_path
    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ff7e146 View commit details
    Browse the repository at this point in the history

  10. use split_first() to handle getting next key nibble

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4b0de0c View commit details
    Browse the repository at this point in the history

  11. bug fix; use split_first() to handle getting next key nibble

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    51cfe7b View commit details
    Browse the repository at this point in the history

  12. cleaunp

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b98dbf2 View commit details
    Browse the repository at this point in the history

  13. implement child helper on BranchNode

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    c0d60ad View commit details
    Browse the repository at this point in the history

  14. nit rename mut_child to child_mut

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0880c23 View commit details
    Browse the repository at this point in the history

  15. change ancestor update logic

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a10872b View commit details
    Browse the repository at this point in the history

  16. re-add TODO

    Dan Laine committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6da5717 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. comment nit

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    bbe321d View commit details
    Browse the repository at this point in the history

  2. remove insert_and_return_ancestors

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    33f2641 View commit details
    Browse the repository at this point in the history

  3. WIP handle node movement upon update in insert

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5e15608 View commit details
    Browse the repository at this point in the history

  4. WIP handle node movement upon update in insert

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2383226 View commit details
    Browse the repository at this point in the history

  5. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2de7402 View commit details
    Browse the repository at this point in the history

  6. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    78e8e08 View commit details
    Browse the repository at this point in the history

  7. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    20eaac4 View commit details
    Browse the repository at this point in the history

  8. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3bca02b View commit details
    Browse the repository at this point in the history

  9. clean up traversal_path

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4d5a206 View commit details
    Browse the repository at this point in the history

  10. renames

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    df06e05 View commit details
    Browse the repository at this point in the history

  11. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e40c5cd View commit details
    Browse the repository at this point in the history

  12. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6aba160 View commit details
    Browse the repository at this point in the history

  13. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9b1cd5b View commit details
    Browse the repository at this point in the history

  14. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    15e8b43 View commit details
    Browse the repository at this point in the history

  15. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    57869ac View commit details
    Browse the repository at this point in the history

  16. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4ef2495 View commit details
    Browse the repository at this point in the history

  17. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    446cf76 View commit details
    Browse the repository at this point in the history

  18. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    78851da View commit details
    Browse the repository at this point in the history

  19. cleanup

    Dan Laine committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5dc7477 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. comment nits

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e3a0017 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/remove-shale' into remove-shale-… 

    …insert-handle-move
    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4e71a84 View commit details
    Browse the repository at this point in the history

  3. nits

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c704ac4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c0dcd42 View commit details
    Browse the repository at this point in the history

  5. WIP implement remove. Allow nodestore's root to be set to None.

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    21a9e06 View commit details
    Browse the repository at this point in the history

  6. WIP implement remove. Uncomment test remove_one

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d9e4e6a View commit details
    Browse the repository at this point in the history

  7. WIP implement remove

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    146f05f View commit details
    Browse the repository at this point in the history

  8. remove unused method

    Dan Laine committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0d43fa6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. combine iterator usages into 1

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    15f5ab4 View commit details
    Browse the repository at this point in the history

  2. cleanup

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a978e8d View commit details
    Browse the repository at this point in the history

  3. add to test

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4a2ee4f View commit details
    Browse the repository at this point in the history

  4. WIP fix leaf removal

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ea5fda6 View commit details
    Browse the repository at this point in the history

  5. WIP fix leaf removal

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4f954b8 View commit details
    Browse the repository at this point in the history

  6. WIP fix leaf removal

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4eb6d58 View commit details
    Browse the repository at this point in the history

  7. uncomment removal test

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    bdb659f View commit details
    Browse the repository at this point in the history

  8. appease clippy

    Dan Laine committed May 15, 2024
    Configuration menu
    Copy the full SHA
    bef03ed View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge remote-tracking branch 'origin/remove-shale' into remove-shale-… 

    …insert-handle-move
    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b135240 View commit details
    Browse the repository at this point in the history

  2. remove unneeded calls to from_nibbles_iterator

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cc19ed4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'remove-shale-insert-handle-move' into remove-shale-impl… 

    …ement-remove
    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4f17a29 View commit details
    Browse the repository at this point in the history

  4. typo fix

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ea0e143 View commit details
    Browse the repository at this point in the history

  5. appease clippy

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f3b1299 View commit details
    Browse the repository at this point in the history

  6. change remove implementation

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e3b8d43 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b951dc4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    940c164 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'remove-shale-insert-handle-move' into remove-shale-impl… 

    …ement-remove
    Dan Laine committed May 16, 2024
    Configuration menu
    Copy the full SHA
    46a1542 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine authored May 17, 2024
    Configuration menu
    Copy the full SHA
    e843730 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'remove-shale' into remove-shale-insert-handle-move

    Dan Laine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dcd5959 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'remove-shale-insert-handle-move' into remove-shale-impl… 

    …ement-remove
    Dan Laine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    da72c19 View commit details
    Browse the repository at this point in the history

  3. fix test

    Dan Laine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ac11dce View commit details
    Browse the repository at this point in the history

  4. fix insertion by cleaning up content at old child address (#654)

    Dan Laine authored May 21, 2024
    Configuration menu
    Copy the full SHA
    00ea8db View commit details
    Browse the repository at this point in the history

  5. Merge branch 'remove-shale-insert-handle-move' into remove-shale-impl… 

    …ement-remove
    Dan Laine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6e9a04f View commit details
    Browse the repository at this point in the history

  6. fix merge

    Dan Laine committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c406a72 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Code review comments 

    Added some additional comments and some tests to make sure the root is
actually gone after deleting everything
    @rkuris
    rkuris committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f60851b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'remove-shale' into remove-shale-implement-remove

    Dan Laine committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a976cea View commit details
    Browse the repository at this point in the history