Skip to content

Commit

Permalink
Remove histograms (#736)
Browse files Browse the repository at this point in the history
  • Loading branch information
rkuris authored Oct 11, 2024
1 parent b1aad78 commit ff24a43
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 1 addition & 4 deletions firewood/src/merkle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::range_proof::RangeProof;
use crate::stream::{MerkleKeyValueStream, PathIterator};
use crate::v2::api;
use futures::{StreamExt, TryStreamExt};
use metrics::{counter, histogram};
use metrics::counter;
use smallvec::SmallVec;
use std::collections::HashSet;
use std::fmt::Debug;
Expand Down Expand Up @@ -416,9 +416,6 @@ impl<S: ReadableStorage> Merkle<NodeStore<MutableProposal, S>> {
/// Map `key` to `value` in the trie.
/// Each element of key is 2 nibbles.
pub fn insert(&mut self, key: &[u8], value: Box<[u8]>) -> Result<(), MerkleError> {
histogram!("firewood.insert.key.length").record(key.len() as f64);
histogram!("firewood.insert.data.length").record(value.len() as f64);

let key = Path::from_nibbles_iterator(NibblesIterator::new(key));

let root = self.nodestore.mut_root();
Expand Down
3 changes: 1 addition & 2 deletions storage/src/nodestore.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use arc_swap::access::DynAccess;
use arc_swap::ArcSwap;
use bincode::{DefaultOptions, Options as _};
use bytemuck_derive::{AnyBitPattern, NoUninit};
use metrics::{counter, histogram};
use metrics::counter;
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::fmt::Debug;
Expand Down Expand Up @@ -492,7 +492,6 @@ impl<S: ReadableStorage> NodeStore<Arc<ImmutableProposal>, S> {
/// Also returns the index of the free list the node was allocated from.
pub fn allocate_node(&mut self, node: &Node) -> Result<(LinearAddress, AreaIndex), Error> {
let stored_area_size = Self::stored_len(node);
histogram!("firewood.node_size").record(stored_area_size as f64);

// Attempt to allocate from a free list.
// If we can't allocate from a free list, allocate past the existing
Expand Down

0 comments on commit ff24a43

Please sign in to comment.