params: add BerlinBlock, LondonBlock, ShanghaiTime #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Sep 23, 2024
darioush
commented
Sep 23, 2024
ARR4N
approved these changes
Sep 25, 2024
ARR4N
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds back BerlinBlock, LondonBlock, ShanghaiTime upgrades from upstream.
This is towards using more upstream packages and activating the desired behaviors via setting the Eth upgrade, instead of directly referencing the Avalanche upgrade names from predominantly upstream code.
This PR does not include modifying any of the Avalanche upgrade to the Eth upgrade, it only prepares the appropriate fields in the chain config.
How this works
In Avalanche AP2 & AP3 upgrades were enabled by timestamp however the corresponding Eth upgrade (Berlin, London) enable via block number. Since these upgrades already occurred, we can use their block numbers for canonical chains and use 0 in tests.
How this was tested
CI. (Note there is no behavioral changes for execution in this PR)