Merge pull request #572 from ava-labs/repo-iter-error

Move error handling to after iteration loop

plugin/evm/atomic_tx_repository.go

@@ -122,10 +122,6 @@ func (a *atomicTxRepository) initializeHeightIndex(lastAcceptedHeight uint64) er
 	// Keep track of the size of the currently pending writes
 	pendingBytesApproximation := 0
 	for iter.Next() {
-		if err := iter.Error(); err != nil {
-			return fmt.Errorf("atomic tx DB iterator errored while initializing atomic trie: %w", err)
-		}
-
 		// iter.Value() consists of [height packed as uint64] + [tx serialized as packed []byte]
 		iterValue := iter.Value()
 		if len(iterValue) < wrappers.LongLen {
@@ -168,6 +164,9 @@ func (a *atomicTxRepository) initializeHeightIndex(lastAcceptedHeight uint64) er
 			log.Info("Atomic repository initialization", "indexedTxs", indexedTxs)
 		}
 	}
+	if err := iter.Error(); err != nil {
+		return fmt.Errorf("atomic tx DB iterator errored while initializing atomic trie: %w", err)
+	}
 
 	// Updated the value stored [maxIndexedHeightKey] to be the lastAcceptedHeight
 	indexedHeight := make([]byte, wrappers.LongLen)