Fix off-by-one error in MaxBlocksPerRequest. (#180)

For each value X, it should accept the range [N,N+X-1], not [N,N+X], e.g. if it's set to 1 it should accept just the single block range [N,N]. https://xkcd.com/2248/ Signed-off-by: aaronbuchwald <[email protected]> Co-authored-by: aaronbuchwald <[email protected]>
ava-labs · Jun 13, 2023 · 91e10ff · 91e10ff
1 parent fd17092
commit 91e10ff
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/eth/filters/filter.go b/eth/filters/filter.go
@@ -171,7 +171,7 @@ func (f *Filter) Logs(ctx context.Context) ([]*types.Log, error) {
 
 	// If the requested range of blocks exceeds the maximum number of blocks allowed by the backend
 	// return an error instead of searching for the logs.
-	if maxBlocks := f.sys.backend.GetMaxBlocksPerRequest(); int64(end)-f.begin > maxBlocks && maxBlocks > 0 {
+	if maxBlocks := f.sys.backend.GetMaxBlocksPerRequest(); int64(end)-f.begin >= maxBlocks && maxBlocks > 0 {
 		return nil, fmt.Errorf("requested too many blocks from %d to %d, maximum is set to %d", f.begin, int64(end), maxBlocks)
 	}
 	// Gather all indexed logs, and finish with non indexed ones