Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-8108: Use AWS Secrets Manager to store envs #1194

Merged
merged 7 commits into from
Feb 26, 2024
Merged

CP-8108: Use AWS Secrets Manager to store envs #1194

merged 7 commits into from
Feb 26, 2024

Conversation

atn4z7
Copy link
Collaborator

@atn4z7 atn4z7 commented Feb 19, 2024

Description

Ticket: CP-8108

Local flow:
run this command whenever you need to update/set up envs
yarn envs

  • will call aws configure sso if aws profile is not set up
  • will call aws sso login if session has expired
  • will call aws secretsmanager get-secret-value to retrieve all envs and create .env files

CI flow:
trigger bitrise-envs-sync github workflow whenever envs are updated on AWS secrets manager

References:

Screenshots/Videos

Screenshot 2024-02-26 at 8 23 19 AM

Testing

you will only need to test the local flow. try to run yarn envs and see if your .env files are updated correctly.

CI flow successful run https://github.com/ava-labs/avalanche-wallet-apps/actions/runs/8014659292

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@atn4z7 atn4z7 marked this pull request as draft February 19, 2024 19:38
@atn4z7 atn4z7 marked this pull request as ready for review February 23, 2024 14:11
@atn4z7 atn4z7 changed the title AWS CP-8108: Use AWS Secrets Manager to store envs Feb 23, 2024
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atn4z7 atn4z7 merged commit 6211ef9 into development Feb 26, 2024
3 checks passed
@atn4z7 atn4z7 deleted the aws branch February 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants