fix: getAddresses popup appearing randomly on core.app #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
commented
Oct 14, 2024
| @@ -3,14 +3,23 @@ import { isSyncDomain } from '@src/background/services/network/utils/getSyncDoma | |||
| import { isActiveTab } from './isActiveTab'; | |||
| import { runtime } from 'webextension-polyfill'; | |||
|
|
|||
| type SkipApprovalOptions = { | |||
| allowInactiveTabs?: boolean; | |||
There was a problem hiding this comment.
I went with dev having to explicitly say allowInactiveTabs rather than making the tabId optional. It feels less error-prone this way.
vvava
approved these changes
Oct 14, 2024
| await canSkipApproval(request.site.domain, request.site.tabId, { | ||
| domainWhitelist: EXPOSED_DOMAINS, | ||
| allowInactiveTabs: true, | ||
| }) |
There was a problem hiding this comment.
Should we put all of the parameters in to an object then?
There was a problem hiding this comment.
I can simplify in a follow up PR (so I don't need to collect approvals after updating again 😄)
ryanewood
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
Expose addresses?popup showing up randomly on core.app.It seems core.app is polling for accounts and reacting to accounts being created/renamed in the extension. If core.app is not the active tab, we show up the approval window.