Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove etna builder minPrice usage and update examples #881

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: remove etna builder minPrice usage and update examples #881

merged 1 commit into from
Oct 9, 2024

Conversation

erictaylor
Copy link
Member

@erictaylor erictaylor commented Oct 9, 2024 •
edited
Loading

  • Removes logic related to minPrice usage.
  • Update Etna examples
  • Add examples script to generate private key and needed .env values.

@erictaylor erictaylor self-assigned this Oct 9, 2024
ruijialin-avalabs
ruijialin-avalabs approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for adding the generate-keys example.

@erictaylor erictaylor merged commit 5b7868a into master Oct 9, 2024
3 checks passed
@erictaylor erictaylor deleted the erictaylor/etna-builder-adjust branch October 9, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruijialin-avalabs ruijialin-avalabs ruijialin-avalabs approved these changes

@rictorlome rictorlome Awaiting requested review from rictorlome

Assignees

@erictaylor erictaylor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erictaylor @ruijialin-avalabs