Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate burned amount for p-chain dynamic fee #880

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Validate burned amount for p-chain dynamic fee #880

merged 9 commits into from
Oct 10, 2024

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Oct 9, 2024 •
edited
Loading

  • refactored validateBurnedAmount to handle static and dynamic burned amount.
  • added a util function to check if etna is enabled from upgradesInfo reponse

rictorlome
rictorlome reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@rictorlome rictorlome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, few comments. Maybe worthwhile to create a folder in utils for all these

src/utils/validateAvaxBurnedAmountEtna.ts Outdated Show resolved Hide resolved
src/utils/validateAvaxBurnedAmountEtna.ts Outdated Show resolved Hide resolved
src/utils/validateAvaxBurnedAmountEtna.ts Outdated Show resolved Hide resolved
src/utils/validateBurnedAmount.ts Outdated Show resolved Hide resolved
rictorlome
rictorlome reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@rictorlome rictorlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

src/utils/validateBurnedAmount/validateAvaxBurnedAmountEtna.test.ts Outdated Show resolved Hide resolved
src/utils/validateBurnedAmount/validateBurnedAmount.ts Outdated Show resolved Hide resolved
src/utils/validateBurnedAmount/validateAvaxBurnedAmountEtna.ts Outdated Show resolved Hide resolved
rictorlome
rictorlome approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@rictorlome rictorlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

erictaylor
erictaylor approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@erictaylor erictaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@ruijialin-avalabs ruijialin-avalabs merged commit 16f420c into master Oct 10, 2024
3 checks passed
@ruijialin-avalabs ruijialin-avalabs deleted the ray/validateBurnedAmount branch October 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictaylor erictaylor erictaylor approved these changes

@rictorlome rictorlome rictorlome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruijialin-avalabs @erictaylor @rictorlome