networkID from /ext/info is a string #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AvalancheGo side, the method
info.getNetworkIDreturns thenetworkIDfield as a string as it's marshaled fromjson.Uint32(defined here). In the client side, however, we receive it as anumber. With this miscast, the client accidentally considers the returned network ID as a hex string, and thus a submitted tx is always rejected due to network id mismatch. For example, when the client sends a tx to Local Network (id=1337), it sets networkID to 0x1337.The proposed fix is to change the type of
networkIDfrom number to string to match AvalancheGo implementation.