[migrate-coreth][5] Migrate CI #4535
Conversation
| # Load the constants | ||
| source "$CORETH_PATH"/scripts/constants.sh | ||
| REPO_ROOT=$( cd "$( dirname "${BASH_SOURCE[0]}" )"; cd .. && pwd ) | ||
| source "$REPO_ROOT"/scripts/constants.sh |
There was a problem hiding this comment.
I didn't see any relevant configuration in the coreth version of this file that wasn't available in the avalanchego version, and figured it was better to use the same file.
maru-ava
force-pushed
the
maru/migrate-coreth-5-ci
branch
2 times, most recently
from
f21c6f2 to
e607ec7
Compare
|
|
||
| EXCLUDED_TARGETS="| grep -v /mocks | grep -v proto | grep -v tests/e2e | grep -v tests/load/c | grep -v tests/upgrade | grep -v tests/fixture/bootstrapmonitor/e2e | grep -v tests/reexecute" | ||
|
|
||
| if [[ "$(go env GOOS)" == "windows" ]]; then |
There was a problem hiding this comment.
Discovered while changing this file - we don't test on windows anymore
| @@ -1,10 +0,0 @@ | |||
| # - Will execute on entry to the containing directory only if authorized with `direnv allow` | |||
There was a problem hiding this comment.
No real reason to include this here but since I do use direnv I was getting annoyed at constantly being asked to allow it to load.
| run: | ||
| description: "the bash script to run e.g. ./scripts/my-script.sh" | ||
| required: true | ||
| working_directory: |
There was a problem hiding this comment.
This was required to allow usage of the action from the graft/coreth path.
| # ./scripts/tests.e2e.sh | ||
| # ./scripts/tests.e2e.sh --ginkgo.label-filter=x # All arguments are supplied to ginkgo | ||
| # E2E_SERIAL=1 ./scripts/tests.e2e.sh # Run tests serially | ||
| # E2E_TARGET=./graft/coreth/tests/warp ./scripts/tests.e2e.sh # Run the warp e2e tests |
There was a problem hiding this comment.
I updated this file to support reuse by the warp suite for consistency of execution across e2e suites
| # Copy and download avalanche dependencies using go mod | ||
| COPY go.mod . | ||
| COPY go.sum . | ||
| COPY graft/coreth ./graft/coreth |
There was a problem hiding this comment.
Without this the subsequent line fails due to the replace directive pointing to a local path
maru-ava
force-pushed
the
maru/migrate-coreth-5-ci
branch
from
4be60d2 to
34bff07
Compare
maru-ava
force-pushed
the
maru/migrate-coreth-5-ci
branch
from
34bff07 to
ac2d18f
Compare
maru-ava
force-pushed
the
maru/migrate-coreth-5-ci
branch
2 times, most recently
from
eedd219 to
af72459
Compare
alarso16
force-pushed
the
maru/migrate-coreth-5-ci
branch
2 times, most recently
from
5e8d6e0 to
8b7b2f8
Compare
|
The coreth unit test failures will be fixed with ava-labs/coreth#1421, but requires a tricky rebase on PR 2 after it's merged. So we can worry about that later |
alarso16
force-pushed
the
maru/migrate-coreth-5-ci
branch
3 times, most recently
from
63b9def to
2764713
Compare
alarso16
force-pushed
the
maru/migrate-coreth-5-ci
branch
from
2764713 to
a7d7eff
Compare
Why this should be merged
Migrates coreth CI to be able to run in this repo.
I highly recommend reviewing this commit by commit, since there's a lot of unrelated lint fixes in this PR. This helps you see the necessary scope
How this was tested
CI
Need to be documented in RELEASES.md?
N/A